Captain's Log: 2013.08.13
- created
Matcher
class
- TDD
Engine
module to be included by oneboxes- refactor
preview
, move url matching functionality toMatcher.oneboxed
- JZ added new oneboxes
- Qik
- StackExchange
- Captain Kurt helped add test for Qik video embedding and make spec DRYer
- we don't know how to grab video embed code yet
- still undecided on how to display videos in regards to autoplay
- embed or linked thumbnail ?
- learned about Null Object
- learned how to autoclose issues with a commit message!
git commit -m "Fixes #[issue number]"
- unable to merge
wikipedia-onebox
branch due to conflicts with master
- learned how to deal with conflicts
git pull --rebase origin master
fix conflicts
git add .
git rebase --continue
git push -f origin wikipedia-onebox
- How to make a good pull request via Robin and Jeff:
Now *this* is how you make a good pull request: https://t.co/WWKEI0OAok
— Robin Ward (@evil_trout) August 14, 2013
Look at this pull request.. LOOK AT IT https://t.co/CzA91l6oQw
— Jeff Atwood (@codinghorror) August 13, 2013
- HOMEWORK:
- refactor tests so more DRY
- Read up on:
- VerbalExpressions for Ruby
parse_open_graph